Improve for multisite #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove kana from customer name if they don't have the data. added validation message into locale. added translation against js validation. update checkout template.
…to improve-for-multisite
|
@magento run Unit Tests |
lenaorobei
reviewed
Jan 9, 2020
lenaorobei
reviewed
Jan 9, 2020
lenaorobei
reviewed
Jan 9, 2020
lenaorobei
reviewed
Jan 9, 2020
lenaorobei
reviewed
Jan 9, 2020
lenaorobei
reviewed
Jan 9, 2020
Co-Authored-By: Lena Orobei <[email protected]>
Co-Authored-By: Lena Orobei <[email protected]>
Co-Authored-By: Lena Orobei <[email protected]>
…to improve-for-multisite
removed class constant and use Magento/Directory/Helper/Data constant.
…o2-jp into improve-for-multisite
|
@magento run Unit Tests |
|
@magento run Static Tests |
lenaorobei
reviewed
Jan 22, 2020
|
|
||
| /** | ||
| * Use name widget that corresponds to Japanese traditions and contains kana fields. | ||
| */ | ||
| class Name | ||
| { | ||
| private $kanaFieldsConfig; |
There was a problem hiding this comment.
Please add PHPDoc block here.
lenaorobei
reviewed
Jan 22, 2020
|
|
||
| /** | ||
| * Use name widget that corresponds to Japanese traditions and contains kana fields. | ||
| */ | ||
| class Name | ||
| { | ||
| private $kanaFieldsConfig; | ||
|
|
||
| public function __construct( |
There was a problem hiding this comment.
Please add PHPDoc block here.
lenaorobei
reviewed
Jan 22, 2020
| @@ -68,4 +90,9 @@ private function walkChildren(array $component): array | |||
| } | |||
| return $component; | |||
| } | |||
|
|
|||
| private function getStoreLocale() | |||
There was a problem hiding this comment.
Please add PHPDoc block here.
lenaorobei
reviewed
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system.xml's definitions are specified as "store", but retrieving system configuration value functions don't have 2nd argument to specify scope. So if Magento users hope to use Magento under multi-site & multi-language environment without kana or Japanese style, they cannot disable kana and other Japanese specific configuration.